refactor(app): report robotType in select events
#17153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes EXEC-629 and RQA-2386
Overview
Product has requested that specific telemetry events also include
robotType, see ticket for which events in particular. A handful of these events no longer exist, and what to do with those events is an ongoing discussion with Product.There were a couple different approaches one could take to reporting events with robotType, including creating wrappers around existing functionality, but most of these are old OT-2 events that use redux observable and unfortunately do not play nicely with hooks.
Test Plan and Hands on Testing
Changelog
robotTypeto select analytics.Risk assessment
None - just analytic changes